Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repeated corruption of packed-refs #438

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix repeated corruption of packed-refs #438

merged 1 commit into from
Jun 12, 2024

Conversation

dims
Copy link
Member

@dims dims commented Jun 12, 2024

We have seen this often enough that we should fix it programatically! most recent was today:
kubernetes/kubernetes#56876 (comment)

We use the algorithm from the discussion we had with @soltysh and @sttts in:
https://kubernetes.slack.com/archives/C2C40FMNF/p1701175768598839?thread_ts=1700688672.734149&cid=C2C40FMNF

Today's discussion was in:
https://kubernetes.slack.com/archives/CHGFYJVAN/p1718172922410299

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from akhilerm and cici37 June 12, 2024 13:26
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2024
@dims
Copy link
Member Author

dims commented Jun 12, 2024

/assign @akhilerm @upodroid

@dims
Copy link
Member Author

dims commented Jun 12, 2024

I've tested with the data we captured here:
https://storage.googleapis.com/k8s-infra-kops-ci-results/packed-refs.txt

upodroid
upodroid requested changes Jun 12, 2024
View reviewed changes
artifacts/scripts/construct.sh Outdated Show resolved Hide resolved
akhilerm
akhilerm suggested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the packed-refs from client-go repo and a few other repos also, except the duplicated first line it works as expected.

@dims dims force-pushed the fix-repeated-corruption-of-packed-refs branch from c5ba185 to 026a573 Compare June 12, 2024 14:45
@dims
Copy link
Member Author

dims commented Jun 12, 2024

Tested with the packed-refs from client-go repo and a few other repos also, except the duplicated first line it works as expected.

I removed the print statement in NR == 1 did that not fix the duplicated line? can you please recheck?

@dims dims force-pushed the fix-repeated-corruption-of-packed-refs branch from 026a573 to 1653e41 Compare June 12, 2024 15:05
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhilerm, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2cb6372 into kubernetes:master Jun 12, 2024
7 checks passed
@akhilerm
Copy link
Member

I removed the print statement in NR == 1 did that not fix the duplicated line? can you please recheck?

Yep, its working fine. The comment was part of the previous review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid requested changes

@akhilerm akhilerm akhilerm approved these changes

@cici37 cici37 Awaiting requested review from cici37

Assignees

@akhilerm akhilerm

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @k8s-ci-robot @akhilerm @upodroid